Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#293 fixed infinite nested loop during metamodel creation #363

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

justTimTim
Copy link
Contributor

Fixed a stack overflow issue during compilation.
Now the depth of creating a metamodel for a field of the same class will be equal to 1, if necessary, it can be increased by the “depth” parameter in the “Indexed” annotation.
I've also removed some code duplication and moved some class creation out of the method logic for easier readability.

ps. I think that for the project it is worth using some kind of single check style.

Copy link
Contributor

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bsbodden bsbodden merged commit f7c4fa6 into redis:main Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants