Allowing poetry and redis-py to install together #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
+ Coverage 93.60% 93.61% +0.01%
==========================================
Files 76 76
Lines 16214 16214
==========================================
+ Hits 15177 15179 +2
+ Misses 1037 1035 -2
Continue to review full report at Codecov.
|
chayim
approved these changes
Jan 10, 2022
chayim
changed the title
dvora-h
pushed a commit
to dvora-h/redis-py
that referenced
this pull request
Jan 11, 2022
This moves packaging to >=20.4 rather than the latest.
return42
added a commit
to return42/searxng
that referenced
this pull request
Jan 17, 2022
This reverts interim fix from commit 50c4b58 and adds requirement `redis==4.1.1`. The interim fix was needed by Alpine images (Docker) [1] and has been fixed in commit [2] merged with the patch series from [3] [1] redis/redis-py#1869 [2] redis/redis-py@1fc1233f [3] redis/redis-py#1854 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Jan 17, 2022
This reverts interim fix from commit 50c4b58 and adds requirement `redis==4.1.1`. The interim fix was needed by Alpine images (Docker) [1] and has been fixed in commit [2] merged with the patch series from [3]. In redis-py version 4.1.1 this pach has been released on PyPi [4]. [1] redis/redis-py#1869 [2] redis/redis-py@1fc1233f [3] redis/redis-py#1854 [4] redis/redis-py#1880 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
not-my-profile
pushed a commit
to not-my-profile/searxng
that referenced
this pull request
Jan 23, 2022
This reverts interim fix from commit 50c4b58 and adds requirement `redis==4.1.1`. The interim fix was needed by Alpine images (Docker) [1] and has been fixed in commit [2] merged with the patch series from [3]. In redis-py version 4.1.1 this pach has been released on PyPi [4]. [1] redis/redis-py#1869 [2] redis/redis-py@1fc1233f [3] redis/redis-py#1854 [4] redis/redis-py#1880 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
dvora-h
pushed a commit
to dvora-h/redis-py
that referenced
this pull request
Jan 25, 2022
This moves packaging to >=20.4 rather than the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Poetry is stuck with packaging ^20.4 (python-poetry/poetry#4752) for a while yet.
I don't see any pressing need for exactly >=21.3 in redis-py at the moment. This change would allow poetry==1.1.12 and redis-py==4.1.0 to be installed together