Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP Stapling Support #1873

Merged
merged 12 commits into from Jan 17, 2022
Merged

OCSP Stapling Support #1873

merged 12 commits into from Jan 17, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jan 11, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the feature New feature label Jan 11, 2022
@chayim chayim changed the title stapled connection OCSP Stapling Support Jan 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #1873 (068b71c) into master (15f315a) will decrease coverage by 0.63%.
The diff coverage is 7.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1873      +/-   ##
==========================================
- Coverage   93.60%   92.97%   -0.64%     
==========================================
  Files          76       76              
  Lines       16214    16389     +175     
==========================================
+ Hits        15177    15237      +60     
- Misses       1037     1152     +115     
Impacted Files Coverage Δ
redis/client.py 89.37% <ø> (ø)
redis/ocsp.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
tests/test_ssl.py 48.46% <19.04%> (-5.67%) ⬇️
redis/connection.py 86.78% <28.57%> (-1.56%) ⬇️
tests/conftest.py 88.73% <0.00%> (-0.91%) ⬇️
tests/test_cluster.py 98.16% <0.00%> (-0.38%) ⬇️
tests/test_search.py 99.07% <0.00%> (+0.05%) ⬆️
redis/cluster.py 92.42% <0.00%> (+0.37%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...068b71c. Read the comment docs.

redis/ocsp.py Outdated Show resolved Hide resolved
redis/ocsp.py Outdated Show resolved Hide resolved
redis/ocsp.py Outdated Show resolved Hide resolved
redis/ocsp.py Outdated Show resolved Hide resolved
redis/connection.py Outdated Show resolved Hide resolved
@chayim chayim merged commit f0c0ab2 into redis:master Jan 17, 2022
@chayim chayim deleted the ck-ocsp-stapled branch January 17, 2022 07:14
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
@whardier
Copy link

whardier commented Dec 4, 2022

Is there any specific reason pyopenssl is pinned in setup.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants