Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async SEARCH pipeline #2316

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Fix async SEARCH pipeline #2316

merged 3 commits into from
Aug 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #2279

@@ -167,5 +167,5 @@ class Pipeline(SearchCommands, redis.client.Pipeline):
"""Pipeline for the module."""


class AsyncPipeline(AsyncSearchCommands, AsyncioPipeline):
class AsyncPipeline(AsyncSearchCommands, AsyncioPipeline, Pipeline):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh

@dvora-h dvora-h merged commit 19cedab into redis:master Aug 2, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
* fix search async pipeline

* newline
kosuke-zhang pushed a commit to uup-saas/redis-py that referenced this pull request Dec 4, 2022
* fix search async pipeline

* newline
@dvora-h dvora-h deleted the a-search-pipeline branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RediSearch: search command doesn't support asyncio Pipeline
2 participants