Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout parameter for SentinelManagedConnection #2495

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

YiuRULE
Copy link
Contributor

@YiuRULE YiuRULE commented Dec 8, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Related to #2488, we set now the timeout parameter for a Sentinel Managed Connection as it's required on the child class.

Not sure exactly how to test this part of the code as an unit test as no test are provided in b0883b7

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 92.22% // Head: 92.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6c2d57a) compared to base (74c251a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
- Coverage   92.22%   92.21%   -0.02%     
==========================================
  Files         113      113              
  Lines       29357    29357              
==========================================
- Hits        27075    27072       -3     
- Misses       2282     2285       +3     
Impacted Files Coverage Δ
redis/asyncio/sentinel.py 87.57% <100.00%> (ø)
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️
tests/test_cluster.py 96.90% <0.00%> (-0.12%) ⬇️
tests/test_asyncio/test_search.py 98.61% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h merged commit 1000a2b into redis:master Dec 25, 2022
@YiuRULE YiuRULE deleted the gt/fix_read_timeout branch December 26, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants