Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for certain LATENCY commands #2503

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 12, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1980
closes #1981
closes #1982

@dvora-h dvora-h requested a review from chayim December 12, 2022 12:53
@dvora-h dvora-h added maintenance Maintenance (CI, Releases, etc) feature New feature and removed maintenance Maintenance (CI, Releases, etc) labels Dec 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Base: 92.19% // Head: 78.74% // Decreases project coverage by -13.45% ⚠️

Coverage data is based on head (bbed266) compared to base (3a121be).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2503       +/-   ##
===========================================
- Coverage   92.19%   78.74%   -13.46%     
===========================================
  Files         113      113               
  Lines       29337    29347       +10     
===========================================
- Hits        27047    23108     -3939     
- Misses       2290     6239     +3949     
Impacted Files Coverage Δ
redis/commands/core.py 81.88% <100.00%> (-0.11%) ⬇️
tests/test_commands.py 89.92% <100.00%> (+0.07%) ⬆️
tests/test_asyncio/test_cluster.py 18.51% <0.00%> (-79.10%) ⬇️
tests/test_cluster.py 18.08% <0.00%> (-78.82%) ⬇️
redis/asyncio/cluster.py 16.96% <0.00%> (-74.72%) ⬇️
redis/cluster.py 18.81% <0.00%> (-71.54%) ⬇️
redis/asyncio/parser.py 17.30% <0.00%> (-63.47%) ⬇️
redis/commands/cluster.py 36.66% <0.00%> (-57.23%) ⬇️
redis/crc.py 45.45% <0.00%> (-54.55%) ⬇️
redis/exceptions.py 86.95% <0.00%> (-11.60%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h changed the title Add support for certain latency commands Add support for certain LATENCY commands Dec 12, 2022
@dvora-h
Copy link
Collaborator Author

dvora-h commented Dec 13, 2022

@shacharPash @vladvildanov

@dvora-h dvora-h merged commit 6487f95 into redis:master Dec 14, 2022
@dvora-h dvora-h deleted the latency-commands branch June 18, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
5 participants