Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept str for ex Parameter in 'set' Command #2529

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Accept str for ex Parameter in 'set' Command #2529

merged 1 commit into from
Jan 5, 2023

Conversation

shacharPash
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Fixes #2178 issue

@shacharPash shacharPash added the bug Bug label Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Base: 92.22% // Head: 92.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0cb6d46) compared to base (f06f3db).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2529   +/-   ##
=======================================
  Coverage   92.22%   92.23%           
=======================================
  Files         113      113           
  Lines       29375    29383    +8     
=======================================
+ Hits        27092    27100    +8     
  Misses       2283     2283           
Impacted Files Coverage Δ
redis/commands/core.py 82.18% <100.00%> (+0.01%) ⬆️
tests/test_commands.py 90.00% <100.00%> (+0.01%) ⬆️
tests/test_cluster.py 96.90% <0.00%> (-0.12%) ⬇️
tests/test_asyncio/test_cluster.py 97.60% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h merged commit 8401da8 into master Jan 5, 2023
@dvora-h dvora-h deleted the issue2178 branch January 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set and expire api diffrent handle to 'expire time' param
3 participants