Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis.from_url() is a misnomer #2638

Closed
curtiscook opened this issue Mar 22, 2023 · 0 comments · Fixed by #2752
Closed

Redis.from_url() is a misnomer #2638

curtiscook opened this issue Mar 22, 2023 · 0 comments · Fixed by #2752
Assignees

Comments

@curtiscook
Copy link

Version: 4.5.2

Platform: Python 3.11.2

Description: Redis.from_url is a convenience function, but the kwargs are passed into the ConnectionPool object and not the Redis instance. This formerly wasn't a problem, but it appears as though auto_close_connection_pool now defaults to true, so you can't reliably use Redis.from_url() in a singleton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants