Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection release after reset #3043

Open
cpvandehey opened this issue Nov 15, 2023 · 0 comments
Open

Redis connection release after reset #3043

cpvandehey opened this issue Nov 15, 2023 · 0 comments

Comments

@cpvandehey
Copy link

Version:
latest - 5.0.1

Platform:
python 3.9 (seems irrelevant)

Description
sync release method
async release method

The above two methods are invoked whenever a long lived connection in a ConnectionPool are finished and to be recycled.

When a "reset" is called:
sync reset method
async reset method

There are issues that come about when in progress connections are released AFTER a different thread/coroutine runs a reset.

I think some basic try/except logic to wrap the release calls in case there are connection errors would be nice. It would also be useful to have any exception while releasing be the catalyst for disconnection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant