Skip to content

Commit

Permalink
Drop Ruby 2.5 like redis-client
Browse files Browse the repository at this point in the history
  • Loading branch information
byroot committed Apr 2, 2024
1 parent 2775519 commit 0060435
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
Expand Up @@ -29,7 +29,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["3.2", "3.1", "3.0", "2.7", "2.6", "2.5", "jruby-9.3.6.0"]
ruby: ["3.2", "3.1", "3.0", "2.7", "2.6", "jruby-9.3.6.0"]
runs-on: ubuntu-latest
env:
LOW_TIMEOUT: "0.01"
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "2.5"
ruby-version: "2.6"
bundler-cache: true
- name: Cache local temporary directory
uses: actions/cache@v4
Expand Down Expand Up @@ -159,7 +159,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "2.5"
ruby-version: "2.6"
bundler-cache: true
- name: Cache local temporary directory
uses: actions/cache@v4
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "2.5"
ruby-version: "2.6"
bundler-cache: true
- name: Cache local temporary directory
uses: actions/cache@v4
Expand Down
5 changes: 4 additions & 1 deletion .rubocop.yml
@@ -1,7 +1,7 @@
inherit_from: .rubocop_todo.yml

AllCops:
TargetRubyVersion: 2.5
TargetRubyVersion: 2.6

Layout/LineLength:
Max: 120
Expand Down Expand Up @@ -56,6 +56,9 @@ Metrics/PerceivedComplexity:
Style/PercentLiteralDelimiters:
Enabled: false

Style/SlicingWithRange:
Enabled: false

Style/TrailingCommaInArrayLiteral:
Enabled: false

Expand Down
3 changes: 1 addition & 2 deletions cluster/test/helper.rb
Expand Up @@ -72,8 +72,7 @@ def redis_cluster_mock(commands, options = {})
port = nil

cluster_subcommands = if commands.key?(:cluster)
commands.delete(:cluster)
.to_h { |k, v| [k.to_s.downcase, v] }
commands.delete(:cluster).transform_keys { |k| k.to_s.downcase }
else
{}
end
Expand Down
2 changes: 1 addition & 1 deletion redis.gemspec
Expand Up @@ -43,7 +43,7 @@ Gem::Specification.new do |s|
s.files = Dir["CHANGELOG.md", "LICENSE", "README.md", "lib/**/*"]
s.executables = `git ls-files -- exe/*`.split("\n").map { |f| File.basename(f) }

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'

s.add_runtime_dependency('redis-client', '>= 0.17.0')
end

0 comments on commit 0060435

Please sign in to comment.