Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis 6.2 to the GitHub Actions test suite #979

Merged
merged 5 commits into from
Mar 20, 2021
Merged

Add Redis 6.2 to the GitHub Actions test suite #979

merged 5 commits into from
Mar 20, 2021

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Feb 24, 2021

Refers to #978

@byroot
Copy link
Collaborator

byroot commented Feb 24, 2021

Sorry but that's not the way to do it. Testing all redis versions against all ruby version creates a giant matric that takes agests to complete.

Just set Redis version to 6.2 in the original main matrix, and add 6.0 in other matrix.

@rhymes
Copy link
Contributor Author

rhymes commented Feb 24, 2021

@byroot, will do! Thanks for the feedback!

@byroot
Copy link
Collaborator

byroot commented Feb 24, 2021

Might want to rebase, I pushed a CI fix.

@rhymes rhymes marked this pull request as ready for review March 20, 2021 19:25
@rhymes
Copy link
Contributor Author

rhymes commented Mar 20, 2021

@byroot sorry for taking so long to circle back on this. I fixed the errors :-)

@byroot byroot merged commit 6542934 into redis:master Mar 20, 2021
@rhymes rhymes deleted the rhymes/add-redis-62-github-actions branch March 21, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants