Avoid DEBUG POPULATE crash at dictExpand OOM (#12363)

Change to use dictTryExpand, return error on OOM.
redis · Jul 1, 2023 · 2617412 · 2617412
1 parent 6bf9b14
commit 2617412
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/debug.c b/src/debug.c
@@ -713,7 +713,10 @@ NULL
         if (getPositiveLongFromObjectOrReply(c, c->argv[2], &keys, NULL) != C_OK)
             return;
 
-        dictExpand(c->db->dict,keys);
+        if (dictTryExpand(c->db->dict, keys) != DICT_OK) {
+            addReplyError(c, "OOM in dictTryExpand");
+            return;
+        }
         long valsize = 0;
         if ( c->argc == 5 && getPositiveLongFromObjectOrReply(c, c->argv[4], &valsize, NULL) != C_OK ) 
             return;