-
Notifications
You must be signed in to change notification settings - Fork 23.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-cluster clean now will clean appendonlydir #10223
Conversation
In redis#9788, now we stores all persistent append-only files in a dedicated directory. The name of the directory is determined by the appenddirname configuration parameter in redis.conf Update create-cluster clean to clean this default directory. Fixes redis#10222
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenyang8094 FYI use case of multiple nodes in one folder.
maybe instead we wanna let each node have a separate folder?
current code gives each one a different appendfilename
.
not sure if some users of this script expect it to sometimes start from old persistence files (on upgrade)?
yes, i also found this after submitting. i also do some cleanups(see if this needed) |
@oranagra Maybe it's a kind of wishful thinking, but I tend to assume this script is only used for toy / test environments. |
@oranagra Got, thank you. |
AFAIK it's only used for test environments as well. |
In #9788, now we stores all persistent append-only files in
a dedicated directory. The name of the directory is determined
by the appenddirname configuration parameter in redis.conf
Update create-cluster clean to clean this default directory.
Each node have a separate folder
appendonlydir-{PORT}
.This PR also do some cleanups, logs and stricter wildcard matching.
Fixes #10222