Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Certificate Revocation List(crl) #11385

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

polaris-alioth
Copy link
Contributor

redis can use tls, but there is no CRL interface. lack of ability to revoke certificates.

@yossigo
Copy link
Member

yossigo commented Oct 13, 2022

@polaris-alioth I support certificate revocation checking, but I'm not sure simply accepting a CRL file is enough to be usable by most users. Who's going to update the file? What are users expected to do when different certs have different CRLs?

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Oct 14, 2022

Perhaps we should aim at supporting OCSP stapling?

I don't mind we also support crl since it's simple and it doesn't require anyting special from the clients.

@polaris-alioth
Copy link
Contributor Author

polaris-alioth commented Oct 17, 2022

I think crl is an optional feature that users can choose to turn on. the person who enables this capability can update it. I also think crl is relatively simple and use friendly.

What are users expected to do when different certs have different CRLs?

I ignored this before. I'll make adjustments soon.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants