Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications #11875

Merged
merged 12 commits into from
Mar 12, 2023
Merged

Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications #11875

merged 12 commits into from
Mar 12, 2023

Commits on Mar 2, 2023

  1. Fix the bug that CLIENT REPLY OFF|SKIP cannot receive Pub/Sub messages 

    This bug seems to be there forever, CLIENT REPLY OFF|SKIP will
mark the client with CLIENT_REPLY_OFF or CLIENT_REPLY_SKIP flags.
With these flags, prepareClientToWrite called by addReply* will
return C_ERR directly. So the client can't receive the Pub/Sub
messages.

In this PR, we clear these flags when sending Pub/Sub messages,
and restore them after sending if any.

Fixes redis#11874
    @enjoy-binbin
    enjoy-binbin committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    de7ce6f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Add CLIENT_PUSHING flag

    @enjoy-binbin
    enjoy-binbin committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3154474 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. code review from oran

    @enjoy-binbin
    enjoy-binbin committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9e6194d View commit details
    Browse the repository at this point in the history

  2. put the assertion in addReplyPushLen

    @enjoy-binbin
    enjoy-binbin committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    eb7f4bf View commit details
    Browse the repository at this point in the history

  3. code review from oran

    @enjoy-binbin
    enjoy-binbin committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    84a70cf View commit details
    Browse the repository at this point in the history

  4. fix sendTrackingMessage redir client

    @enjoy-binbin
    enjoy-binbin committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7786a93 View commit details
    Browse the repository at this point in the history

  5. more tests. Tests cover all modified code paths

    @enjoy-binbin
    enjoy-binbin committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9a8fc31 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. CR from oran 

    Co-authored-by: Oran Agra <oran@redislabs.com>
    @enjoy-binbin @oranagra
    enjoy-binbin and oranagra committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c0e90ec View commit details
    Browse the repository at this point in the history

  2. another unit: client reply on/off/skip tests

    @enjoy-binbin
    enjoy-binbin committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    955c5a2 View commit details
    Browse the repository at this point in the history

  3. fix test pong->PONG

    @enjoy-binbin
    enjoy-binbin committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    03cb230 View commit details
    Browse the repository at this point in the history

  4. Add a ping in these tracking tests, expecting PONG

    @enjoy-binbin
    enjoy-binbin committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0b962e7 View commit details
    Browse the repository at this point in the history

  5. remove $rd_redir subscribe __redis__:invalidate

    @enjoy-binbin
    enjoy-binbin committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7635f73 View commit details
    Browse the repository at this point in the history