Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GETEX db delete call to emit DB_FLAG_KEY_EXPIRED on expiration #12243

Merged
merged 1 commit into from May 29, 2023

Conversation

enjoy-binbin
Copy link
Collaborator

We should emit DB_FLAG_KEY_EXPIRED instead of DB_FLAG_KEY_DELETED.
This is an overlook in #9406.

We should emit DB_FLAG_KEY_EXPIRED instead of DB_FLAG_KEY_DELETED.
This is an overlook in redis#9406.
@oranagra oranagra merged commit 0dfb025 into redis:unstable May 29, 2023
13 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_dbGenericDelete_call branch May 29, 2023 12:56
@oranagra
Copy link
Member

oranagra commented Jul 2, 2023

should we mention this in the release notes? (considering it's a minor bug that only exists in a pre-release and will be solved in the GA)

@enjoy-binbin
Copy link
Collaborator Author

well. It is a minor bug, so i guess we can skip the release note. But on the other hand, there is no harm mention it in the release notes, i prefer to add it to releade notes

@oranagra
Copy link
Member

oranagra commented Jul 2, 2023

had that bug existed in an actual release, then i'd probably want to mention it.
but beside being minor, and besides the fact it exists in a module API that i doubt is actually being used by anyone, it also only exists in a pre-release.
so in the rare chance that someone is actually affected, they'll probably upgrade anyway (even without being alerted by the release notes).
on the other hand, if that fix could have had some adverse effect, then they should know before upgrading, but i don't think that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants