Cluster: Don't crash when adding a forgotten node to blacklist twice #12702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjoy-binbin
approved these changes
Oct 27, 2023
madolson
reviewed
Oct 27, 2023
madolson
approved these changes
Oct 31, 2023
oranagra
added
the
release-notes
oranagra
changed the title
oranagra
pushed a commit
to oranagra/redis
that referenced
this pull request
Nov 1, 2023
) Add a defensive checks to prevent double freeing a node from the cluster blacklist. (cherry picked from commit 8d67595)
Merged
oranagra
pushed a commit
that referenced
this pull request
Nov 1, 2023
Add a defensive checks to prevent double freeing a node from the cluster blacklist. (cherry picked from commit 8d67595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12701
This is defensive code to avoid the problem. I haven't reproduced the crash though.