Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition issues between the main thread and module threads #12817

Merged
merged 41 commits into from Jan 19, 2024
Merged

Fix race condition issues between the main thread and module threads #12817

merged 41 commits into from Jan 19, 2024
+130 −58

Commits on Nov 28, 2023

  1. Fix race condition issues between the main thread and module threads

    @sundb
    sundb committed Nov 28, 2023
    Copy the full SHA
    ecdf99c View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Let RM_Reply*() and RM_UnblockClient() inside GIL

    @sundb
    sundb committed Dec 4, 2023
    Copy the full SHA
    716ef44 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Add from_module paramter to moduleBlockedClientTimeOut() to make … 

    …it thread-safe
    @sundb
    sundb committed Dec 5, 2023
    Copy the full SHA
    6e4de39 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @sundb
    sundb committed Dec 5, 2023
    Copy the full SHA
    c09ff05 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Make sure don't touch anything before acquire GIL 

    Add `moduleOwnsGIL()` to determine if GIL is acquired by current thread, instead of using `ProcessingEventsWhileBlocked
`
    @sundb
    sundb committed Dec 6, 2023
    Copy the full SHA
    152e7f2 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @sundb
    sundb committed Dec 6, 2023
    Copy the full SHA
    e6a08af View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Upwaord the free of bg

    @sundb
    sundb committed Dec 8, 2023
    Copy the full SHA
    49937df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'unstable' into thread-safe-freeclient

    @sundb
    sundb committed Dec 8, 2023
    Copy the full SHA
    761f5dd View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Fix adding fake client to server.clients_pending_write

    @sundb
    sundb committed Dec 12, 2023
    Copy the full SHA
    15db3fc View commit details
    Browse the repository at this point in the history

  2. Add c->conn null assertion for updateClientMemoryUsage() and updateCl… 

    …ientMemUsageAndBucket()
    @sundb
    sundb committed Dec 12, 2023
    Copy the full SHA
    14c0aa9 View commit details
    Browse the repository at this point in the history

  3. improve comment

    @sundb
    sundb committed Dec 12, 2023
    Copy the full SHA
    1bad868 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. lock the ae poll block and cache modules size

    @sundb
    sundb committed Dec 16, 2023
    Copy the full SHA
    4b48f42 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Added __thread specifier for ProcessingEventsWhileBlocked

    @sundb
    sundb committed Dec 18, 2023
    Copy the full SHA
    dfb5665 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Optimize el mutex variable names, and add comments

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    f9c27e9 View commit details
    Browse the repository at this point in the history

  2. Add comment for modules_count

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    0f1e787 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary line and update comment

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    d5ded67 View commit details
    Browse the repository at this point in the history

  4. update comment

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    07f8de1 View commit details
    Browse the repository at this point in the history

  5. change lock_ae to lock_el

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    0741699 View commit details
    Browse the repository at this point in the history

  6. update comment

    @sundb
    sundb committed Dec 19, 2023
    Copy the full SHA
    1ed674f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Add comment about freeing argvs in module thread

    @sundb
    sundb committed Dec 20, 2023
    Copy the full SHA
    eeda5e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Merge branch 'unstable' into thread-safe-freeclient

    @sundb
    sundb committed Jan 7, 2024
    Copy the full SHA
    eaa21da View commit details
    Browse the repository at this point in the history

  2. Revert some codes after redis#12905

    @sundb
    sundb committed Jan 7, 2024
    Copy the full SHA
    e26eeb9 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary change

    @sundb
    sundb committed Jan 7, 2024
    Copy the full SHA
    c660f6e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Call RM_BlockedClientMeasureTimeStart() and RM_BlockedClientMeasureTi… 

    …meEnd() within GIL
    @sundb
    sundb committed Jan 9, 2024
    Copy the full SHA
    d272368 View commit details
    Browse the repository at this point in the history

  2. Add comment about thread safe for RM_FreeString, RM_RetainString and … 

    …RM_HoldString
    @sundb
    sundb committed Jan 9, 2024
    Copy the full SHA
    70b78ae View commit details
    Browse the repository at this point in the history

  3. cleanup

    @sundb
    sundb committed Jan 9, 2024
    Copy the full SHA
    8bc235f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'unstable' into thread-safe-freeclient

    @sundb
    sundb committed Jan 9, 2024
    Copy the full SHA
    496d0db View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Revert "Call RM_BlockedClientMeasureTimeStart() and RM_BlockedClientM… 

    …easureTimeEnd() within GIL"

This reverts commit d272368.
    @sundb
    sundb committed Jan 10, 2024
    Copy the full SHA
    a47cba0 View commit details
    Browse the repository at this point in the history

  2. Terminate module block thread first in timeout callback

    @sundb
    sundb committed Jan 10, 2024
    Copy the full SHA
    7be865f View commit details
    Browse the repository at this point in the history

  3. Revert "Terminate module block thread first in timeout callback" 

    This reverts commit 7be865f.
    @sundb
    sundb committed Jan 10, 2024
    Copy the full SHA
    54524ca View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Avoid calling RM_BlockedClientMeasureTimeEnd in the main thread

    @sundb
    sundb committed Jan 11, 2024
    Copy the full SHA
    17efc14 View commit details
    Browse the repository at this point in the history

  2. Indent

    @sundb
    sundb committed Jan 11, 2024
    Copy the full SHA
    54cdf01 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Revert "Indent" 

    This reverts commit 54cdf01.
    @sundb
    sundb committed Jan 12, 2024
    Copy the full SHA
    588eff4 View commit details
    Browse the repository at this point in the history

  2. Revert "Avoid calling RM_BlockedClientMeasureTimeEnd in the main thread" 

    This reverts commit 17efc14.
    @sundb
    sundb committed Jan 12, 2024
    Copy the full SHA
    cd8b6a3 View commit details
    Browse the repository at this point in the history

  3. Using local lock instead of GIL to protect RM_BlockedClientMeasureTim… 

    …e* api
    @sundb
    sundb committed Jan 12, 2024
    Copy the full SHA
    0bc0796 View commit details
    Browse the repository at this point in the history

  4. Add comments

    @sundb
    sundb committed Jan 12, 2024
    Copy the full SHA
    a06d7dd View commit details
    Browse the repository at this point in the history

  5. fix crash

    @sundb
    sundb committed Jan 12, 2024
    Copy the full SHA
    d9c18af View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Add new method blockClientPrivdataInit

    @sundb
    sundb committed Jan 14, 2024
    Copy the full SHA
    42de713 View commit details
    Browse the repository at this point in the history

  2. Add api comment for RM_BlockedClientMeasureTimeStart() and RM_Blocked… 

    …ClientMeasureTimeEnd()
    @sundb
    sundb committed Jan 14, 2024
    Copy the full SHA
    393af9e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Update src/module.c 

    Co-authored-by: Oran Agra <oran@redislabs.com>
    @sundb @oranagra
    sundb and oranagra committed Jan 19, 2024
    Copy the full SHA
    70d5348 View commit details
    Browse the repository at this point in the history

  2. Update comments about retained string 

    Co-authored-by: oranagra <oran@redislabs.com>
    @sundb @oranagra
    sundb and oranagra committed Jan 19, 2024
    Copy the full SHA
    1359fad View commit details
    Browse the repository at this point in the history