-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defragger improvements around large bins #12996
Conversation
@oranagra EDIT: fotget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. i edited the top comment a bit since it seemed outdated.
PTAL
Co-authored-by: Oran Agra <oran@redislabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redis/core-team please approve
What is the point of showing muzzy to end users? Maybe after merging this we can improve the documentation around memory. It's something that people ask me about at AWS, since it's confusing. |
@madolson AFAIK, muzzy is very similar to retained, but muzzy is no longer reused but retained is. |
from my understanding that's wrong.
we should surely improve documentation. |
approved in a core-team meeting. |
This field was added in redis#12996 but forgot to add it in json file. This also causes reply-schemas-validator to fail.
Redis-doc PR: redis/redis-doc#2672 |
This field was added in #12996 but forgot to add it in json file. This also causes reply-schemas-validator to fail.
In redis/redis#12996 we add a new `allocator_muzzy` field for `INFO MEMORY` and `MEMORY STATS`. Also update MEMORY-STATS.md for missing fields.
Implement #12963
Changes
large bins when measuring fragmentation, and only measure fragmentation of small bins. this affects both the allocator_frag* metrics and also the active-defrag trigger
allocator_muzzy
memory, which is memory returned to the OS but still shows as RSS until the OS reclaims it.allocator.muzzy
toMEMORY STATS