Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HSETXX #13083

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from
Open

Implement HSETXX #13083

wants to merge 3 commits into from

Conversation

Cheban1996
Copy link

@Cheban1996 Cheban1996 commented Feb 21, 2024 •
edited

zuiderkwast
zuiderkwast reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but it needs to be decided by the core team. There are other alternatives, as discussed in #9058.

I think HSETNX and HSETXX should accept multiple fields (just like MSET), but that's just my personal opinion. Let's wait for opinions from the core team.

src/commands/hsetxx.json Outdated Show resolved Hide resolved
src/commands/hsetxx.json Outdated Show resolved Hide resolved
@zuiderkwast zuiderkwast added the state:major-decision Requires core team consensus label Feb 22, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
state:major-decision Requires core team consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cheban1996 @CLAassistant @zuiderkwast