Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mmap rand bits as a temporary mitigation to resolve asan bug #13150

Merged
merged 1 commit into from Mar 17, 2024

Conversation

madolson
Copy link
Contributor

@madolson madolson commented Mar 17, 2024

There is a new change in linux kernel 6.6.6 that uses randomization of address space to harden security, but it interferes with the way ASAN works. Folks are working on a fix, but this is a temporary mitigation for us to get our CI to be green again.

See google/sanitizers#1716 for more information

See https://github.com/redis/redis/actions/runs/8305126288/job/22731614306?pr=13149 for a recent failure

@madolson madolson requested a review from oranagra March 17, 2024 05:25
@oranagra oranagra merged commit 3f725b8 into redis:unstable Mar 17, 2024
13 checks passed
@oranagra
Copy link
Member

just to be sure i understand.
it broke because the OS image started using a new kernel, and it'll get resolved once the compiler is upgraded to a version that works around it, right?
meanwhile, are we losing anything by applying the change in this PR? i suppose not.
what do we need to watch in order to know when we need to revert this?

@sundb
Copy link
Collaborator

sundb commented Mar 17, 2024

@oranagra the compiler doesn't matter, as soon as actions/runner-images#9491 is complete we can revert it.

@oranagra
Copy link
Member

ok, but in any way i assume we're not losing anything if we forget.

@oranagra
Copy link
Member

meanwhile, i'll mark it for backport

@enjoy-binbin
Copy link
Collaborator

enjoy-binbin commented Mar 21, 2024

for the record, actions/runner-images#9491 (comment) has been fixed

i tested that the code after revert can pass: https://github.com/enjoy-binbin/redis/actions/runs/8368922790

enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants