Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete stale comment about "define redis_fsync" #13204

Closed
wants to merge 1 commit into from

Conversation

zyf0330
Copy link

@zyf0330 zyf0330 commented Apr 11, 2024

See this stale comment when read source code.

@sundb
Copy link
Collaborator

sundb commented Apr 11, 2024

why stale? missing the comment about fcntl?

@zyf0330
Copy link
Author

zyf0330 commented Apr 11, 2024

why stale? missing the comment about fcntl?

Yes. I think add comment about macos fcntl is redundant.

@sundb
Copy link
Collaborator

sundb commented Apr 11, 2024

@zyf0330 if not modified, i perfer to leave it as it's, which doesnt affect understanding.

@zyf0330
Copy link
Author

zyf0330 commented Apr 11, 2024

OK

@zyf0330 zyf0330 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants