Adds lpoprpush, rpoprpush and lpoplpush commands #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new commands are symmetrical to the rpoplpush command, and they've been implemented using a generic method with the existing pattern of a flag begin REDIS_HEAD or REDIS_TAIL to indicate the start or end of a list.
|
Hi, When will this will be available ? |
|
I guess it's better later than never. I finally finished this, and have created a new pull request, so I'll closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new commands are symmetrical to the rpoplpush command, and they've been implemented using a generic method with the existing pattern of a flag being REDIS_HEAD or REDIS_TAIL to indicate the start or end of a list. But I still need help resolving the blocking methods (blpoprpush an so on) and creating tests, because I'm don't know anything about tcl.
I implemented the blocking commands, but I still need to adapt the
serveClientBlockedOnListfunction so that it knows the difference between all methods (it currently supports only the rpoplpush command).