Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Add newlen == 0 handling to RM_StringTruncate (#3717) #3718

Merged
merged 7 commits into from Jun 22, 2021

Commits on Jul 12, 2019

  1. modules: Add newlen == 0 handling to RM_StringTruncate (redis#3717)

    Previously, passing 0 for newlen would not truncate the string at all.
    
    This adds handling of this case, freeing the old string and creating a new empty string.
    neomantra committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    a7d07b1 View commit details
    Browse the repository at this point in the history
  2. modules: add test for RedisModule_StringTruncate and fixup TestAssert…

    …XXXReply functions
    
     * adds TEST.STRING.TRUNCATE and includes it in TEST.IT
    
       This test fails unless issue redis#3717 is resolved
    
     * add handling for ERROR replies in TestAssertStringReply and TestAssertIntegerReply
    
       Previously these TestAssert functions would output something like,
        `<test> Unexpected reply type 1`
       rather than emitting the error message of what was wrong.
    neomantra committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    a3c33b0 View commit details
    Browse the repository at this point in the history
  3. improve module build/test tooling

     * add `test-module` make target
    
     * `make distclean` now cleans module src/test directories
    
     * `runtest-moduleapi` now builds and exercises `testmodule`
    
     * add `clean` target for `commandfilter`
    
     * add `.gitignore` for `commandfilter`
    
     * typo "SOME TEST NOT PASSED!" -> "SOME TEST DID NOT PASS!"
    neomantra committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    595b272 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Merge remote-tracking branch 'origin/unstable' into StringTruncate_ne…

    …wLenZero
    
     Conflicts:
    	runtest-moduleapi
    	src/Makefile
    	tests/modules/Makefile
    oranagra committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    07bc260 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    46618b0 View commit details
    Browse the repository at this point in the history
  3. fix code review comments

    oranagra committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f0097eb View commit details
    Browse the repository at this point in the history
  4. remove excessive gitignore

    oranagra committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    65e100f View commit details
    Browse the repository at this point in the history