Zset int problem #4519
Merged
Zset int problem #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @soloestoy! Merged. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Dec 17, 2018
Zset int problem
pulllock
pushed a commit
to pulllock/redis
that referenced
this pull request
Jun 28, 2023
Zset int problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another int problem found in zset ... @antirez
BTW, I think we fall into the trap of implicit cast, also happens when flush aof in PR #4498 , so we should check all the type carefully.
And I think we can get more detail memory analysis in issue #4504