Support password rotation: allow Redis to accept an alternative password #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to achieve password rotation with no downtime in production: 1. Set requirepass-alt to the old password, requirepass to a new password 2. Notify all users to switch to the new password 3. Confirm that old password is not used, then remove requirepass-alt
Count and show the number of requirepass/requirepass-alt matches. During password rotation, these stats can help server admin check if all clients have switched to the new password.
|
@antirez We had briefly talked about need for this feature when we met at RedisConf 2018. Can you please review when you get a chance? Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #4942
Introduces a
requirepass-altoption, in order to achieve password rotation with no downtime. Here's our solution:requirepass-alt <old-password>, andrequirepass <new-password>requirepass-altTo help server admin check if all clients do start to use the new password, we count the number of requirepass/requirepass-alt matches, and show it in the INFO STATS section.