Providing murmur2 method implementation of the HyperLogLog algorithm to Lua #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oranagra @itamarhaber What's our policy regarding adding extensions to lua? I'm curious as to why this was required? Perhaps another approach would be to develop a redis module and then call its commands from the script? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is adding the MurmurHash2 functionality to Redis.
The patch consists of the code change which includes the murmur2 method implementation of the HyperLogLog algorithm to Lua and trailing zeros check. Tests were done on the Mac OS X 10.13.6, and Linux 4.9.93-linuxkit-aufs x86_64, and are provided as well. Extensive usage of the patch is happening on the Linux 3.10.0-862.3.3.el7.x86_64 system.
After the tests, we have concluded that: