BITCOUNT: fix segmentation fault. #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unsafe and unnecessary cast. until now, this cast may lead segmentation fault when end > UINT_MAX # example setbit foo 0 1 bitcount 0 4294967295 => ok bitcount 0 4294967296 => cause segmentation fault.
|
Milestone set to 2.6, fixing asap, thanks for reporting. |
|
Fix merged, thank you! I also changed the type of strlen to long to work with the same type, and added a regression test. |
antirez
added a commit
that referenced
this pull request
Sep 5, 2012
Bug #582 was not present in 32 bit builds of Redis as getObjectFromLong() will return an error for overflow. This commit makes sure that the test does not fail because of the error returned when running against 32 bit builds.
antirez
added a commit
that referenced
this pull request
Sep 5, 2012
Bug #582 was not present in 32 bit builds of Redis as getObjectFromLong() will return an error for overflow. This commit makes sure that the test does not fail because of the error returned when running against 32 bit builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unsafe and unnecessary cast.
until now, this cast may lead segmentation fault when end > UINT_MAX
example
setbit foo 0 1
bitcount foo 0 4294967295
=> ok
bitcount foo 0 4294967296
=> cause segmentation fault.