Initial implementation of the module I/O filter API #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSully
commented
May 30, 2019
| * Redis Object representing the argument. */ | ||
| if (c->reqtype == PROTO_REQ_MULTIBULK && c->multibulklen && c->bulklen != -1 | ||
| && c->bulklen >= PROTO_MBULK_BIG_ARG) | ||
| for (;;) // read from socket until EAGAIN is returned |
There was a problem hiding this comment.
This is of particular importance. We need to ensure we fully flush all buffers before returning as epoll only checks the kernel's buffer.
|
I still think this is a net good idea, however the whole implementation has now moved to the connection abstraction so all this code is just conflicting now. Any chance you want to update it? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based upon discussions in the modssl project. This change allows modules to filter socket I/O so they can do interesting things like support SSL encryption. I've explicitly overriden the read/write system calls to readWithFilter, writeWithFilter, etc. This is to be explicit however it would be possible to just override them with a #define and reduce the churn.
Note: Replication and Cluster support are not yet tested. Coming soon.