missing per-skiplist overheads in MEMORY USAGE #6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
p.s. some aspects of MEMORY USAGE use zmalloc_size so they include internal fragmentation, but others do not (like the use of sdsAllocSize instead of sdsZmallocSize). |
these had severe impact for small zsets, for instance ones with just one element that is longer than 64 (causing it not to be ziplist encoded)
oranagra
force-pushed
the
skiplist-mem-usage
branch
from
65cdf6e
to
41c5ebc
Compare
|
@oranagra thanks, merged. Yes it makes sense to include internal fragmentation indeed. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Jul 15, 2019
missing per-skiplist overheads in MEMORY USAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these had severe impact for small zsets, for instance ones with just one
element that is longer than 64 (causing it not to be ziplist encoded)