Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log an error message when RM_CreateCommand fails parsing its flags #6380

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

gavrie
Copy link
Contributor

@gavrie gavrie commented Sep 12, 2019

While writing a Redis module, we called RM_CreateCommand with a typo in the strflags argument ("write " instead of "write"). This caused loading of the module to fail with a generic error message: Can't load module from <module file>: server aborting.

It took a while to understand what the actual problem was. It would have been great to see a clear error message that explained what the problem was.

This PR adds such an error message.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants