Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write replies if close the client ASAP #7202

Merged
merged 7 commits into from Sep 24, 2020
Merged

Don't write replies if close the client ASAP #7202

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4e3512
Fix writing replies to async-closed clients
ShooterIT Sep 17, 2020
08a932c
Won't write replies if close the client ASAP
ShooterIT Sep 17, 2020
9a9a00b
Update tests/unit/obuf-limits.tcl
ShooterIT Sep 18, 2020
8d39f02
Remove loading check
ShooterIT Sep 24, 2020
6767ae4
Add transaction and multi commands tests for output buffer limit
ShooterIT Sep 24, 2020
102e050
Check client is closed explicitly
ShooterIT Sep 24, 2020
272ea6b
Reconnect explicitly and check disconnection by name
ShooterIT Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/unit/obuf-limits.tcl
View file
Open in desktop
Expand Up @@ -137,6 +137,7 @@ start_server {tags {"obuf-limits"}} {
}

# Output buffer limit is enforced during executing transaction
r client setname transactionclient
r set k1 v1
r multi
r set k2 v2
Expand All @@ -145,6 +146,9 @@ start_server {tags {"obuf-limits"}} {
r set k3 v3
r del k1
catch {[r exec]} e
oranagra marked this conversation as resolved.
Show resolved Hide resolved
assert_match "*I/O error*" $e
set clients [r client list]
assert_no_match "*name=transactionclient*" $clients
reconnect
ShooterIT marked this conversation as resolved.
Show resolved Hide resolved

# Transactions should be executed completely
Expand Down