Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] redis-check-rdb support for auxiliary from modules #7826

Merged
merged 5 commits into from
Sep 22, 2020
Merged

[BUG] redis-check-rdb support for auxiliary from modules #7826

merged 5 commits into from
Sep 22, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Sep 21, 2020 •
edited
Loading

Fix #7808

oranagra
oranagra reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jut to be sure, have you tested it on an RDB file with a "before" module aux entry?
i.e. to be sure it can continue parsing the file cleanly after it..

src/redis-check-rdb.c Outdated Show resolved Hide resolved
src/redis-check-rdb.c Outdated Show resolved Hide resolved
src/redis-check-rdb.c Outdated Show resolved Hide resolved
src/redis-check-rdb.c Outdated Show resolved Hide resolved
@oranagra
Update src/redis-check-rdb.c
f8ad20c 
Co-authored-by: Oran Agra <oran@redislabs.com>
oranagra
oranagra reviewed Sep 21, 2020
View reviewed changes
src/rdb.c Show resolved Hide resolved
oranagra
oranagra previously approved these changes Sep 22, 2020
View reviewed changes
@oranagra oranagra merged commit 63a05dd into redis:unstable Sep 22, 2020
@ashtul ashtul deleted the fix-redis-check-rdb-RDB_OPCODE_RESIZEDB branch September 22, 2020 07:26
@ashtul ashtul mentioned this pull request Sep 22, 2020
Closed
oranagra pushed a commit to oranagra/redis that referenced this pull request Oct 26, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (redis#7826)
f0df2bb 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
oranagra pushed a commit to oranagra/redis that referenced this pull request Oct 26, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (redis#7826)
d5a1b06 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
@oranagra oranagra mentioned this pull request Oct 26, 2020
Merged
oranagra pushed a commit to oranagra/redis that referenced this pull request Oct 26, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (redis#7826)
99f70e6 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
oranagra pushed a commit that referenced this pull request Oct 27, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (#7826)
77f91e0 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
oranagra pushed a commit that referenced this pull request Oct 27, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (#7826)
6a4da49 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (redis#7826)
1ce5f91 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
@ashtul @jschmieg
Fix redis-check-rdb support for modules aux data (redis#7826)
72fce87 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
pulllock pushed a commit to pulllock/redis that referenced this pull request Jun 28, 2023
@ashtul @oranagra
Fix redis-check-rdb support for modules aux data (redis#7826)
c8d00e5 
redis-check-rdb was unable to parse rdb files containing module aux data.

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 63a05dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oranagra oranagra oranagra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] redis-check-rdb is broken for module .rdb files with auxiliary
2 participants
@ashtul @oranagra