Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new commands ZDIFF and ZDIFFSTORE #7961

Merged
merged 25 commits into from Nov 15, 2020
Merged

Add new commands ZDIFF and ZDIFFSTORE #7961

merged 25 commits into from Nov 15, 2020

Commits on Oct 25, 2020

  1. Add new commands ZDIFF and ZDIFFSTORE

    @felipou
    felipou committed Oct 25, 2020
    Copy the full SHA
    965ece1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/unstable' into zdiffstore

    @felipou
    felipou committed Oct 25, 2020
    Copy the full SHA
    ee7ca2f View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Add algorithm 2 option to zdiff 

    It's the same algorithm used in SDIFF, modified to work with zsets
in zdiff/zdiffstore.
    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    c292f36 View commit details
    Browse the repository at this point in the history

  2. Add sort step to algorithm 1 of zdiff

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    b39b3be View commit details
    Browse the repository at this point in the history

  3. Add extra cardinality check to zdiff algorithm 2

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    64b561f View commit details
    Browse the repository at this point in the history

  4. Use dict iteration directly to find max element length

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    95c78ed View commit details
    Browse the repository at this point in the history

  5. Revert changes to help.h adding zdiff/zdiffstore

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    8ed99fd View commit details
    Browse the repository at this point in the history

  6. Remove unused variables from zdiffAlgorithm2

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    d147091 View commit details
    Browse the repository at this point in the history

  7. Adjusted the note about the error when lacking keys for eviction

    @felipou
    felipou committed Oct 28, 2020
    Copy the full SHA
    e7d226c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Make all new internal functions static

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    1efe956 View commit details
    Browse the repository at this point in the history

  2. Extract function zsetslDel from zsetDel and zdiffAlgorithm2

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    0abf6c8 View commit details
    Browse the repository at this point in the history

  3. Change eviction write commands note to text suggested by oranagra

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    72c51f8 View commit details
    Browse the repository at this point in the history

  4. Fix leak by properly releasing dict iterator

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    d521048 View commit details
    Browse the repository at this point in the history

  5. Rename new zset internal functions

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    58d541b View commit details
    Browse the repository at this point in the history

  6. Fix internal function call names after name change

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    fc05b83 View commit details
    Browse the repository at this point in the history

  7. Fix zdiff algorithms complexity in code comments

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    f7444fc View commit details
    Browse the repository at this point in the history

  8. Minor optimization to zdiff 

    If any other set is equal to the first set in zdiff, we're subtracting
the set from itself, so we already know we'll have an empty set as a
result.
    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    8d631da View commit details
    Browse the repository at this point in the history

  9. Add extra comment about algorithm cost in zdiff algorithm 2

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    2e4b312 View commit details
    Browse the repository at this point in the history

  10. Remove comment that became useless in zdiff algorithm 1

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    0472a32 View commit details
    Browse the repository at this point in the history

  11. Add more tests for zdiff

    @felipou
    felipou committed Oct 31, 2020
    Copy the full SHA
    714e08e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2020

  1. Add back same set check with extra comments

    @felipou
    felipou committed Nov 1, 2020
    Copy the full SHA
    ac31448 View commit details
    Browse the repository at this point in the history

  2. Rename function zsetslDel to zsetRemoveFromSkiplist

    @felipou
    felipou committed Nov 1, 2020
    Copy the full SHA
    23a3c14 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Remove check for nan 

    This check was copied from the zunion/zinter commands code, but is
not needed for zdiff since it doesn't have the WEIGHTS argument.
    @felipou
    felipou committed Nov 11, 2020
    Copy the full SHA
    c7132a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Update algorithm complexities as per review suggestions 

    Review suggestions by oranagra

Co-authored-by: Oran Agra <oran@redislabs.com>
    @felipou @oranagra
    felipou and oranagra committed Nov 13, 2020
    Copy the full SHA
    dc119ed View commit details
    Browse the repository at this point in the history

  2. Syntax error for z(diff/inter/union)store if using WITHSCORES argument

    @felipou
    felipou committed Nov 13, 2020
    Copy the full SHA
    540a78b View commit details
    Browse the repository at this point in the history