Make full use of aofrwblock's buf #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make aof rewrite buffer memory size more accurate, before, there may be 20% deviation with its real memory usage.
oranagra
added
the
state:to-be-merged
oranagra
previously approved these changes
May 27, 2021
oranagra
reviewed
May 27, 2021
ShooterIT
commented
May 27, 2021
| /* This function is different from aofRewriteBufferSize, to get memory usage, | ||
| * we should also count all other fields(except 'buf') of aofrwblock and the | ||
| * last block's free size. */ | ||
| unsigned long aofRewriteBufferMemoryUsage(void) { |
There was a problem hiding this comment.
hi @oranagra here, i should let you know, if we want to get aof rewrite buffer more accurate, we maybe use zmalloc_size to get every aof_rewrite_buf_block, but as you said, it costs much time, so I actually cumulate all aof_rewrite_buf_blocks zmalloc_usable_size, of course, they(zmalloc_size and zmalloc_usable_size) have no difference if allocator has MALLOC SIZE.
oranagra
approved these changes
May 30, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
Make aof rewrite buffer memory size more accurate, before, there may be 20% deviation with its real memory usage. The implication are both lower memory usage, and also a more accurate INFO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AOF_RW_BUF_BLOCK_SIZE is 10M, if we use jemalloc, we will get 12M actually when we alloc aofrwblock, but we only use 10M, there is 20% waste of memory.
If we want to get aof rewrite buffer memory usage, we should also count all other fields(except 'buf') of aofrwblock and the last block's free size. Before, there may be 20% deviation with its real memory usage.