Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support regex in "--only" in runtest #9352

Merged
merged 1 commit into from Aug 10, 2021
Merged

support regex in "--only" in runtest #9352

merged 1 commit into from Aug 10, 2021

Conversation

yoav-steinberg
Copy link
Contributor

No description provided.

@oranagra
Copy link
Member

Thanks!!
What happens now if we attempt to run a test that have a . in it's name? coincidentally it'll still work, right? but in other cases we'll need escaping?

@oranagra oranagra added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label Aug 10, 2021
@yoav-steinberg
Copy link
Contributor Author

Thanks!!
What happens now if we attempt to run a test that have a . in it's name? coincidentally it'll still work, right? but in other cases we'll need escaping?

Yes. If there's a $ in the test name you might have issues if you don't escape.

@oranagra oranagra merged commit 19bc837 into redis:unstable Aug 10, 2021
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Sep 8, 2021
@yoav-steinberg
support regex in "--only" in runtest (redis#9352)
5493224
valentinogeron added a commit to valentinogeron/redis that referenced this pull request May 17, 2022
@valentinogeron
Fix regex support in --only, --skipfile and --skiptest
6535dbc 
The regex support was added in:
 * redis#9352
 * redis#9555
 * redis#10212

These commits break backword compatiblity with older versions.

The fix is in `search_pattern_list` utility. First, it does string match,
and only then (if needed) uses the regex
@valentinogeron valentinogeron mentioned this pull request May 17, 2022
Merged
valentinogeron added a commit to valentinogeron/redis that referenced this pull request May 18, 2022
@valentinogeron
Fix regex support in --only, --skipfile and --skiptest
6eed110 
The regex support was added in:
 * redis#9352
 * redis#9555
 * redis#10212

These commits break backword compatiblity with older versions.

This fix keeps the testsuite infra compatible with old versions by
default. If you want regex the string must start with `/`
oranagra pushed a commit that referenced this pull request May 25, 2022
@valentinogeron
Fix regex support in --only, --skipfile and --skiptest (#10741)
9eb97b5 
The regex support was added in:
 * #9352
 * #9555
 * #10212

These commits break backword compatiblity with older versions.

This fix keeps the test suite infra compatible with old versions by
default. However, if you want regex, the string must start with `/`
Mixficsol pushed a commit to Mixficsol/redis that referenced this pull request Apr 12, 2023
@valentinogeron @Mixficsol
Fix regex support in --only, --skipfile and --skiptest (redis#10741)
b073cfe 
The regex support was added in:
 * redis#9352
 * redis#9555
 * redis#10212

These commits break backword compatiblity with older versions.

This fix keeps the test suite infra compatible with old versions by
default. However, if you want regex, the string must start with `/`
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
@valentinogeron @enjoy-binbin
Fix regex support in --only, --skipfile and --skiptest (redis#10741)
d8f415c 
The regex support was added in:
 * redis#9352
 * redis#9555
 * redis#10212

These commits break backword compatiblity with older versions.

This fix keeps the test suite infra compatible with old versions by
default. However, if you want regex, the string must start with `/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oranagra oranagra oranagra approved these changes

Assignees
No one assigned
Labels
state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoav-steinberg @oranagra