Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out the mess around writable replicas and lookupKeyRead/Write #9572

Merged
merged 24 commits into from
Nov 28, 2021

Commits on Oct 14, 2021

  1. Sort out the mess around writable replicas and lookupKeyRead/Write

    Writable replicas now no longer use the data of expired keys. Expired keys
    are deleted when lookupKeyWrite() is used, even on a writable replica.
    
    This commit also sorts out the mess around the commands lookupKeyRead() and
    lookupKeyWrite() so they now indicate what we intend to do with the key and
    are not be affected by the command itself.
    
    Multi-key commands like sunionstore, zinterstore, copy and sort with the
    store option now use lookupKeyRead() for the keys they're reading from, but
    with flags preserving the legacy behaviour (not touching keyspace hits/misses
    counters, etc.).
    zuiderkwast committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    c09c811 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
    zuiderkwast and yoav-steinberg committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    c002931 View commit details
    Browse the repository at this point in the history
  3. Fixup: Review suggestions

    zuiderkwast committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    49b2c48 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    710e9d9 View commit details
    Browse the repository at this point in the history
  5. Fixup: spelling typo

    zuiderkwast committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ef55207 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    068e7a1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    562b96f View commit details
    Browse the repository at this point in the history
  8. Fix the assert in expireIfNeeded for eval and debug loadaof + stuff

    Set current_client to AOF client during AOF loading.
    
    Add an assert forbidding the WRITE flag in lookupKeyReadWithFlags.
    
    Extra: Don't touch keys stats and LRU when determining ASK redirect.
    zuiderkwast committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3b1e307 View commit details
    Browse the repository at this point in the history
  9. Add test cases

    zuiderkwast committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6f01fb0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    32a7045 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Fix review comments

    zuiderkwast committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    cca77ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a439aa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Configuration menu
    Copy the full SHA
    aecc32c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Review comments

    zuiderkwast committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    34d1119 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Configuration menu
    Copy the full SHA
    260c454 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Configuration menu
    Copy the full SHA
    c78d43e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ee4d68 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Configuration menu
    Copy the full SHA
    623ca03 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    323dffc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5def78 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Configuration menu
    Copy the full SHA
    ae46106 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d091ef9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef10a77 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Configuration menu
    Copy the full SHA
    34676f9 View commit details
    Browse the repository at this point in the history