-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort out the mess around writable replicas and lookupKeyRead/Write #9572
Merged
Commits on Oct 14, 2021
-
Sort out the mess around writable replicas and lookupKeyRead/Write
Writable replicas now no longer use the data of expired keys. Expired keys are deleted when lookupKeyWrite() is used, even on a writable replica. This commit also sorts out the mess around the commands lookupKeyRead() and lookupKeyWrite() so they now indicate what we intend to do with the key and are not be affected by the command itself. Multi-key commands like sunionstore, zinterstore, copy and sort with the store option now use lookupKeyRead() for the keys they're reading from, but with flags preserving the legacy behaviour (not touching keyspace hits/misses counters, etc.).
Configuration menu - View commit details
-
Copy full SHA for c09c811 - Browse repository at this point
Copy the full SHA c09c811View commit details -
Apply suggestions from code review
Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
Configuration menu - View commit details
-
Copy full SHA for c002931 - Browse repository at this point
Copy the full SHA c002931View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b2c48 - Browse repository at this point
Copy the full SHA 49b2c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 710e9d9 - Browse repository at this point
Copy the full SHA 710e9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef55207 - Browse repository at this point
Copy the full SHA ef55207View commit details -
Configuration menu - View commit details
-
Copy full SHA for 068e7a1 - Browse repository at this point
Copy the full SHA 068e7a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562b96f - Browse repository at this point
Copy the full SHA 562b96fView commit details -
Fix the assert in expireIfNeeded for eval and debug loadaof + stuff
Set current_client to AOF client during AOF loading. Add an assert forbidding the WRITE flag in lookupKeyReadWithFlags. Extra: Don't touch keys stats and LRU when determining ASK redirect.
Configuration menu - View commit details
-
Copy full SHA for 3b1e307 - Browse repository at this point
Copy the full SHA 3b1e307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f01fb0 - Browse repository at this point
Copy the full SHA 6f01fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32a7045 - Browse repository at this point
Copy the full SHA 32a7045View commit details
Commits on Oct 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cca77ac - Browse repository at this point
Copy the full SHA cca77acView commit details -
Configuration menu - View commit details
-
Copy full SHA for a439aa9 - Browse repository at this point
Copy the full SHA a439aa9View commit details
Commits on Oct 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aecc32c - Browse repository at this point
Copy the full SHA aecc32cView commit details
Commits on Oct 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 34d1119 - Browse repository at this point
Copy the full SHA 34d1119View commit details
Commits on Oct 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 260c454 - Browse repository at this point
Copy the full SHA 260c454View commit details
Commits on Nov 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c78d43e - Browse repository at this point
Copy the full SHA c78d43eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ee4d68 - Browse repository at this point
Copy the full SHA 0ee4d68View commit details
Commits on Nov 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 623ca03 - Browse repository at this point
Copy the full SHA 623ca03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 323dffc - Browse repository at this point
Copy the full SHA 323dffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5def78 - Browse repository at this point
Copy the full SHA f5def78View commit details
Commits on Nov 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ae46106 - Browse repository at this point
Copy the full SHA ae46106View commit details -
Configuration menu - View commit details
-
Copy full SHA for d091ef9 - Browse repository at this point
Copy the full SHA d091ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef10a77 - Browse repository at this point
Copy the full SHA ef10a77View commit details
Commits on Nov 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 34676f9 - Browse repository at this point
Copy the full SHA 34676f9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.