Merge pull request #484 from redis/fix-graph-constraint-builders

feat: GRAPH.CONSTRAINT CREATE builder
redis · Feb 29, 2024 · ded6852 · ded6852
2 parents 16d5f13 + 544ec4b
commit ded6852
Show file tree

Hide file tree

Showing 4 changed files with 260 additions and 7 deletions.
diff --git a/hack/cmds/commands_graph.json b/hack/cmds/commands_graph.json
@@ -138,11 +138,107 @@
   "GRAPH.CONSTRAINT DROP": {
     "summary": "Deletes a constraint from specified graph",
     "since": "2.12.0",
-    "group": "graph"
+    "group": "graph",
+    "arguments": [
+      {
+        "name": "key",
+        "type": "key"
+      },
+      {
+        "name": "mode",
+        "type": "oneof",
+        "arguments": [
+          {
+            "name": "MANDATORY",
+            "type": "pure-token",
+            "token": "MANDATORY"
+          },
+          {
+            "name": "UNIQUE",
+            "type": "pure-token",
+            "token": "UNIQUE"
+          }
+        ]
+      },
+      {
+        "name": "entity",
+        "type": "oneof",
+        "arguments": [
+          {
+            "name": "NODE",
+            "type": "string",
+            "command": "NODE"
+          },
+          {
+            "name": "RELATIONSHIP",
+            "type": "string",
+            "command": "RELATIONSHIP"
+          }
+        ]
+      },
+      {
+        "name": "PROPERTIES",
+        "command": "PROPERTIES",
+        "type": "integer"
+      },
+      {
+        "name": "PROP",
+        "type": "string",
+        "multiple": true
+      }
+    ]
   },
   "GRAPH.CONSTRAINT CREATE": {
     "summary": "Creates a constraint on specified graph",
     "since": "2.12.0",
-    "group": "graph"
+    "group": "graph",
+    "arguments": [
+      {
+        "name": "key",
+        "type": "key"
+      },
+      {
+        "name": "mode",
+        "type": "oneof",
+        "arguments": [
+          {
+            "name": "MANDATORY",
+            "type": "pure-token",
+            "token": "MANDATORY"
+          },
+          {
+            "name": "UNIQUE",
+            "type": "pure-token",
+            "token": "UNIQUE"
+          }
+        ]
+      },
+      {
+        "name": "entity",
+        "type": "oneof",
+        "arguments": [
+          {
+            "name": "NODE",
+            "type": "string",
+            "command": "NODE"
+          },
+          {
+            "name": "RELATIONSHIP",
+            "type": "string",
+            "command": "RELATIONSHIP"
+          }
+        ]
+      },
+      {
+        "name": "PROPERTIES",
+        "command": "PROPERTIES",
+        "type": "integer"
+      },
+      {
+        "name": "PROP",
+        "type": "string",
+        "multiple": true
+      }
+    ]
   }
 }
diff --git a/hack/cmds/gen.go b/hack/cmds/gen.go
@@ -9,6 +9,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"reflect"
 	"sort"
 	"strings"
 	"unicode"
@@ -413,7 +414,9 @@ func main() {
 			n.Walk(func(n *node) {
 				for _, s := range n.GoStructs() {
 					if v, ok := structs[g][s.FullName]; ok {
-						panic("struct conflict " + v.FullName)
+						if !reflect.DeepEqual(v, s) {
+							panic("struct conflict " + v.FullName)
+						}
 					}
 					structs[g][s.FullName] = s
 				}

diff --git a/internal/cmds/gen_graph.go b/internal/cmds/gen_graph.go
diff --git a/internal/cmds/gen_graph_test.go b/internal/cmds/gen_graph_test.go