Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RedisResult.AsBoolSlice() #499

Closed
rueian opened this issue Mar 16, 2024 · 3 comments
Closed

Add RedisResult.AsBoolSlice() #499

rueian opened this issue Mar 16, 2024 · 3 comments
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rueian
Copy link
Collaborator

rueian commented Mar 16, 2024

We have .AsIntSlice() and .AsStrSlice(), but we don't have .AsBoolSlice().

The recent rueidisprob implementation shows that .AsBoolSlice() could be worth adding.
https://github.com/redis/rueidis/pull/493/files#diff-4b47f96f7b3ee7e0e6e518500c78b9968b6ae21a4cc1edf422b18e285dcfe2d5R276-R295

@rueian rueian added help wanted Extra attention is needed good first issue Good for newcomers feature labels Mar 16, 2024
@Ali-Assar
Copy link
Contributor

I see where the changes should be added. I think .AsBoolSlice() should be added in message.go if you are ok with that. I can work on this issue.

@rueian
Copy link
Collaborator Author

rueian commented Mar 16, 2024

Hi @Ali-Assar, I am surely ok with that. Thank you for your interest in working on this. Contributions are always welcome.

@Ali-Assar
Copy link
Contributor

Hi. I created a pull request named: Add RedisResult.AsBoolSlice() #499 #500.
I created AsBoolSlice() and also tested it and tests are working fine.

rueian added a commit that referenced this issue Mar 17, 2024
Add RedisResult.AsBoolSlice() #499
@rueian rueian closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants