doc: add comments to ConnWriteTimeout as a request timeout
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Feb 16, 2024
rueidis.go
Outdated
| // ConnWriteTimeout is applied net.Conn.SetWriteDeadline and periodic PING to redis | ||
| // ConnWriteTimeout is read/write timeout for each connection. If specified, | ||
| // it is used to control the maximum duration waits for responses to pipeline commands. | ||
| // Also, ConnWriteTimeout is applied net.Conn.SetWriteDeadline and periodic PING to redis |
There was a problem hiding this comment.
Suggested change
| // Also, ConnWriteTimeout is applied net.Conn.SetWriteDeadline and periodic PING to redis | |
| // Also, ConnWriteTimeout is applied net.Conn.SetDeadline and periodic PING to redis |
Sorry, the original comment was wrong. It should be SetDeadline.
There was a problem hiding this comment.
15a95c5. Yeap. you're right!
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 95.65% 95.66%
=======================================
Files 63 63
Lines 31765 31765
=======================================
+ Hits 30384 30387 +3
+ Misses 1185 1183 -2
+ Partials 196 195 -1 ☔ View full report in Codecov by Sentry. |
|
Merged! Thanks @proost! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous disccusion: #468
Add comments that
ConnWriteTimeoutcan be request timeout to commands