Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOVALUES support to HSCAN #503

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Add NOVALUES support to HSCAN #503

merged 2 commits into from
Mar 18, 2024

Conversation

Exzrgs
Copy link
Contributor

@Exzrgs Exzrgs commented Mar 17, 2024

Hi, I resolved #501
I added NOVALUES block.

Signed-off-by: Exzrgs <s.nakao0120@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (236216b) to head (d1dda33).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          80       80           
  Lines       33090    33102   +12     
=======================================
+ Hits        31628    31640   +12     
  Misses       1261     1261           
  Partials      201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian
Copy link
Collaborator

rueian commented Mar 17, 2024

Hi @Exzrgs, thanks! Please also run go generate

Signed-off-by: Exzrgs <s.nakao0120@gmail.com>
@Exzrgs
Copy link
Contributor Author

Exzrgs commented Mar 17, 2024

@rueian
Sorry, I've run the command in other directory by mistake!
I run the command in the right place and push the commit!

@rueian rueian added the feature label Mar 18, 2024
@rueian rueian self-requested a review March 18, 2024 17:50
@rueian rueian merged commit 45c79f4 into redis:main Mar 18, 2024
1 check passed
@rueian
Copy link
Collaborator

rueian commented Mar 18, 2024

Hi @Exzrgs, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NOVALUES support to HSCAN
3 participants