Skip to content

Commit

Permalink
refactor: Moved scan size estimator to RIOT
Browse files Browse the repository at this point in the history
  • Loading branch information
jruaux committed Apr 27, 2024
1 parent 2352dd1 commit 4a4c075
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 200 deletions.
1 change: 0 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jacocoVersion = 0.8.11
kordampBuildVersion = 3.4.0
kordampPluginVersion = 0.54.0

globVersion = 0.9.0
lettucemodVersion = 3.7.3
testcontainersRedisVersion = 2.2.2

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
import com.redis.spring.batch.reader.KeyNotificationItemReader;
import com.redis.spring.batch.reader.MemKeyValue;
import com.redis.spring.batch.reader.MemKeyValueRead.ValueType;
import com.redis.spring.batch.reader.ScanSizeEstimator;
import com.redis.spring.batch.reader.StreamItemReader;
import com.redis.spring.batch.reader.StreamItemReader.AckPolicy;
import com.redis.spring.batch.util.BatchUtils;
Expand Down Expand Up @@ -311,19 +310,6 @@ void compareStatus(TestInfo info) throws Exception {
assertEquals(deleted, comparisons.stream().filter(c -> c.getStatus() == Status.MISSING).count());
}

@Test
void estimateScanSize(TestInfo info) throws Exception {
GeneratorItemReader gen = generator(3000, Item.Type.HASH, Item.Type.STRING);
generate(info, gen);
long expectedCount = redisCommands.dbsize();
ScanSizeEstimator estimator = new ScanSizeEstimator(redisClient);
estimator.setKeyPattern(GeneratorItemReader.DEFAULT_KEYSPACE + ":*");
estimator.setSamples(300);
assertEquals(expectedCount, estimator.getAsLong(), expectedCount / 10);
estimator.setKeyType(DataType.HASH.getString());
assertEquals(expectedCount / 2, estimator.getAsLong(), expectedCount / 10);
}

@Test
void readStruct(TestInfo info) throws Exception {
generate(info, generator(73));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
dependencies {
api 'org.springframework:spring-core'
implementation group: 'com.redis', name: 'lettucemod', version: lettucemodVersion
implementation group: 'com.hrakaroo', name: 'glob', version: globVersion
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
import java.io.InputStreamReader;
import java.nio.ByteBuffer;
import java.util.function.Function;
import java.util.function.Predicate;
import java.util.function.Supplier;

import org.springframework.util.FileCopyUtils;

import com.hrakaroo.glob.GlobPattern;
import com.redis.lettucemod.RedisModulesClient;
import com.redis.lettucemod.api.StatefulRedisModulesConnection;
import com.redis.lettucemod.cluster.RedisModulesClusterClient;
Expand Down Expand Up @@ -83,7 +81,4 @@ public static <K, V> StatefulRedisModulesConnection<K, V> connection(RedisModule
return connection;
}

public static Predicate<String> globPredicate(String match) {
return GlobPattern.compile(match)::matches;
}
}

This file was deleted.

0 comments on commit 4a4c075

Please sign in to comment.