[BUG] Remove empty tag values #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/fork_gc.c
Outdated
| uint64_t *id) { | ||
| if (FGC_recvBuffer(fgc, (void **)fieldName, fieldNameLen) != REDISMODULE_OK) { | ||
| static FGCError recvNumericTagHeader(ForkGC *fgc, tagNumHeader *header, int type) { | ||
| size_t tagValLen; |
There was a problem hiding this comment.
No, but we cannot pass NULL to FGC_recvBuffer.
ashtul
commented
Oct 5, 2021
src/fork_gc.c
Outdated
| uint64_t *id) { | ||
| if (FGC_recvBuffer(fgc, (void **)fieldName, fieldNameLen) != REDISMODULE_OK) { | ||
| static FGCError recvNumericTagHeader(ForkGC *fgc, tagNumHeader *header, int type) { | ||
| size_t tagValLen; |
There was a problem hiding this comment.
No, but we cannot pass NULL to FGC_recvBuffer.
| IndexIterator **its; | ||
| uint32_t uid; |
There was a problem hiding this comment.
We do not use this?
There was a problem hiding this comment.
@MeirShpilraien
Since I use TagIndex with TagIndex_OpenIndex to retrieve the inverted index of the tag value.
MeirShpilraien
approved these changes
Oct 5, 2021
ashtul
pushed a commit
that referenced
this pull request
Oct 5, 2021
* [BUG] Remove empty tag values * Remove comment * test cursor * Per Meir review * clean up * init ptr (cherry picked from commit 4aa6f9b)
ashtul
pushed a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix updates ForkGC to remove empty tag values from the trie. This caused a leak.
This bug affected indexes where TAG fields are updated with new values while the old, deleted values are left in the trie.