Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a screenshot of the running application to the README #14

Closed
simonprickett opened this issue Oct 8, 2021 · 2 comments · Fixed by #15
Closed

Add a screenshot of the running application to the README #14

simonprickett opened this issue Oct 8, 2021 · 2 comments · Fixed by #15
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest 2021 help wanted Extra attention is needed

Comments

@simonprickett
Copy link
Contributor

simonprickett commented Oct 8, 2021

Update README.md to add a screenshot of the running application, showing the map view with the solar site markers on it. For this you will need to follow the instructions in the README to get the application running. You'll also need to replace the stub implementation of findAll in com.redislabs.university.RU102J.dao.SiteDaoRedisImpl with the code from the solutions branch

to get your map working... as the code on master has this as a training exercise for the course that this repo is part of.

This is part of our participation in Hacktoberfest 2021. Learn how to complete this issue here: https://developer.redis.com/hacktoberfest/

Need help or want to talk to us? Join us on Discord where we have a dedicated Hacktoberfest channel: https://discord.gg/ueQwKUh5Z3

@simonprickett simonprickett added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Hacktoberfest 2021 labels Oct 8, 2021
@mohan-13
Copy link
Contributor

Hello! I would like to pick this up. Please assign to me. Thanks

@simonprickett
Copy link
Contributor Author

Thanks @mohan-13 I have assigned you this issue and we will take a look at your PR today UK time.

SuzeShardlow added a commit that referenced this issue Oct 10, 2021
Adds application screenshot to README

Closes #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest 2021 help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants