Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan In cluster mode, other nodes cannot be scanned #4238

Closed
dongmaxiang opened this issue Apr 18, 2022 · 2 comments
Closed

Scan In cluster mode, other nodes cannot be scanned #4238

dongmaxiang opened this issue Apr 18, 2022 · 2 comments
Labels
bug
Milestone
3.17.1

Comments

@dongmaxiang
Copy link

Expected behavior
The iterator returned by SCAN can scan all nodes

Actual behavior
But only one node will be scanned

Steps to reproduce or test case
In cluster mode, run the scan command

Redisson version
All versions have this problem

Redisson configuration
Cluster mode: Three master and three slave
dongmaxiang pushed a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
Fixed - In cluster mode, all nodes cannot be scanned，Not a single red…
eb9accc 
…isson#4238
@dongmaxiang
Copy link
Author

dongmaxiang commented Apr 18, 2022 •
edited

When I asked this question, I found the solution and the cause of the problem。
But I don't know if it's right, and if it's disrupting Redisson's design patterns

The reason is that the field client in the implementation of ScanCursor will affect the current entry node, resulting in the acquisition of connection is always the same node, and the node cannot be switched. In addition, I have mentioned mergeRequest,
one：#4241
two：#4242
please give me more advice if there is something wrong

dongmaxiang pushed a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
Fixed - In cluster mode, all nodes cannot be scanned，Not only a singl…
e6f889a 
…e node redisson#4238
dongmaxiang pushed a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
Fixed - In cluster mode, all nodes cannot be scanned，Not only a singl…
e7871b3 
…e node redisson#4238

Signed-off-by: anyOne <caoleike@300.cn>
dongmaxiang added a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
@dongmaxiang
Fixed - In cluster mode, all nodes cannot be scanned，Not only a singl…
79d2582 
…e node redisson#4238

Signed-off-by: Old Cao <clk5858@163.com>
Signed-off-by: anyOne <caoleike@300.cn>
dongmaxiang added a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
@dongmaxiang
Fixed - all scan, In cluster mode, all nodes cannot be scanned，Not on…
c8883ee 
…ly a single node redisson#4238

Signed-off-by: old Cao <clk5858@163.com>
dongmaxiang added a commit to dongmaxiang/redisson that referenced this issue Apr 18, 2022
@dongmaxiang
Fixed - RedisClusterNode scan, In cluster mode, all nodes cannot be s…
0261f99 
…canned，Not only a single node redisson#4238

Signed-off-by: old Cao <clk5858@163.com>
This was referenced Apr 18, 2022
Closed
Closed
@mrniko mrniko added this to the 3.17.1 milestone Apr 19, 2022
@mrniko mrniko added the bug label Apr 19, 2022
mrniko pushed a commit that referenced this issue Apr 19, 2022
Fixed - Spring Data Redis module. Scan In cluster mode, other nodes c…
347e0dd 
…annot be scanned #4238
@mrniko
Copy link
Member

mrniko commented Apr 19, 2022

Fixed! Thanks for report

@mrniko mrniko closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
3.17.1
Development

No branches or pull requests
2 participants
@mrniko @dongmaxiang