New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incUsage is not called when acquireConnection -> createConnection #4441
Comments
Fixed. Thanks for report |
You fixed the message connection but neglected the pubsub connection. When acquire create new pubsub connection, incUsage in ConnectionPool without checking PubSubConnectionPool will lead usage to become 1. |
Fixed. Thanks for code review. |
incUsage is not called when acquireConnection -> createConnection
but decUsage is still called when releasrConnection, which lead usage to become -1
after this, PingConnectionHandler will behave incorrectly:
Expected behavior
incUsage is called when acquireConnection
Actual behavior
incUsage is called when acquire exist free connection
incUsage is not called when acquire create new connection
Steps to reproduce or test case
freeConnections size < acquireConnection size
for example (pseudo-code):
Redis version
6.2.6
Redisson version
3.17.4
Redisson configuration
connectionMinimumIdleSize: 1
connectionPoolSize: 8
pingConnectionInterval: 5000
idleConnectionTimeout: 10000
【acquire exist free connection】【release correctly:0 to 1 to 0】
【acquire create new connection】【release incorrectly:0 to -1】
【PingConnectionHandler behavior】
The text was updated successfully, but these errors were encountered: