Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring session integration #452

Closed
mrniko opened this issue Mar 27, 2016 · 2 comments
Closed

Add Spring session integration #452

mrniko opened this issue Mar 27, 2016 · 2 comments
Labels
Milestone

Comments

@mrniko
Copy link
Member

mrniko commented Mar 27, 2016

No description provided.

@mrniko mrniko added the feature label Mar 27, 2016
@ziadloo
Copy link

ziadloo commented Mar 27, 2016

My knowledge in this area is absolutely limited but I guess adding Spring Session integration is pointless. My original proposition to use Redisson as a session manager was due to the lack of distributed locks within Spring Session. This shortcoming is a result of being bounded to HttpSession's interface and the fact that it doesn't provide any APIs to lock the session. If Redisson is going to act under the same interface of HttpSession, it adds no value to the original Spring Session + Clustered Redis implementation!

As I said at the beginning of my comment, I'm not an expert but if this is really the case, I think the true value to the Redisson is the fact that it supports distributed locks. And this functionality can not be delivered through HttpSession's interface.

And just for the record, locking the whole session for some user is not really useful. The true value is in locking session entries one by one. Locking the whole session as one slows the overall responding by a great deal and is impractical.

And one more thing, not every access to a session entry needs to establish a lock! Locking an entry should be explicit, most of the times we need a shared access just to read the content of an entry and unnecessary locking could also lead to bad performance.

@mrniko mrniko added this to the 2.7.0 milestone Nov 18, 2016
mrniko pushed a commit that referenced this issue Nov 21, 2016
mrniko pushed a commit that referenced this issue Nov 22, 2016
@mrniko
Copy link
Member Author

mrniko commented Nov 22, 2016

Done

@mrniko mrniko closed this as completed Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants