fix: ClientConnectionsEntry reconnect error #3455
Conversation
Signed-off-by: mika <mikawudi@qq.com>
| private AtomicBoolean initConnError = new AtomicBoolean(false); | ||
| @Override | ||
| public void accept(Void r, Throwable ex) { | ||
| synchronized (this) { |
There was a problem hiding this comment.
we don't need to use synchronized here since we use thread-safe initConnError
| if (!initConnError.compareAndSet(false, true)) { | ||
| return; | ||
| } | ||
| for (RedisConnection connection : entry.getAllConnections()) { |
There was a problem hiding this comment.
don't we do this already at
?
| if (!initConnError.compareAndSet(false, true)) { | ||
| return; | ||
| } | ||
| entry.closeAllConnections(); |
There was a problem hiding this comment.
If it's already closed at https://github.com/redisson/redisson/pull/3455/files#diff-637ba54fb9190054f7e2ae91ce22f27a77371807e352055a3131017713a84f23R135
why do we need to close it again?
There was a problem hiding this comment.
u are right, it's my wrong, i will roll back it
|
Please check this comment #3455 (comment) |
Signed-off-by: xujie <mikawudi@qq.com>
| @@ -131,21 +131,21 @@ public void run() { | |||
| if (initPromise.isDone()) { | |||
| return; | |||
| } | |||
|
|
|||
| if (ex == null) { | ||
| listener.decCounter(); | ||
| } else { | ||
| if (!initConnError.compareAndSet(false, true)) { |
There was a problem hiding this comment.
i think we need this check, beacuse initCallBack will called by slaveConnectionPool and pubSubConnectionPool completed, but only can reset initialized status once
Signed-off-by: xujie <mikawudi@qq.com>
| @@ -131,21 +131,18 @@ public void run() { | |||
| if (initPromise.isDone()) { | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
please remove this file from changeset
There was a problem hiding this comment.
i roll back this file to you last commit
Signed-off-by: xujie <mikawudi@qq.com>
|
Thanks for contribution! |
slaveConnectionPool can't reconnect in sentinel model
ref: #3442
Signed-off-by: mika mikawudi@qq.com