Add support for bounded Redisson map cache (max size configuration). #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnou
changed the title
johnou
changed the title
johnou
commented
Jul 24, 2017
| final int maxSize = 2; | ||
| Map<String, String> store = new LinkedHashMap<String, String>() { | ||
| @Override | ||
| protected boolean removeEldestEntry(Entry<String, String> eldest) { |
There was a problem hiding this comment.
required as store represents an onheap cache, not the cache in redis.
mrniko
requested changes
Aug 28, 2017
| " end;" + | ||
| " end;" + | ||
| "end;" + | ||
| "return map;", | ||
| Arrays.<Object>asList(getName(), getTimeoutSetName(), getIdleSetName()), args.toArray()); |
There was a problem hiding this comment.
@johnou getLastAccessTimeSetName() is missed
| + "return 0; " | ||
| + "end", | ||
| Arrays.<Object>asList(getName(key), getTimeoutSetNameByKey(key), getIdleSetNameByKey(key), getRemovedChannelNameByKey(key), | ||
| getLastAccessTimeSetName()), |
There was a problem hiding this comment.
@johnou getLastAccessTimeSetNameByKey should be used instead
| + "return val;" | ||
| + "end; ", | ||
| Arrays.<Object>asList(getName(key), getTimeoutSetNameByKey(key), getIdleSetNameByKey(key), getCreatedChannelNameByKey(key), | ||
| getLastAccessTimeSetName(), getRemovedChannelName()), |
There was a problem hiding this comment.
@johnou getLastAccessTimeSetNameByKey, getRemovedChannelNameByKey should be used instead
| + "end; ", | ||
| Arrays.<Object>asList(getName(key), getTimeoutSetNameByKey(key), getIdleSetNameByKey(key), getCreatedChannelNameByKey(key)), | ||
| System.currentTimeMillis(), ttlTimeout, maxIdleTimeout, maxIdleDelta, encodeMapKey(key), encodeMapValue(value)); | ||
| "local insertable = false; " |
There was a problem hiding this comment.
@johnou please format this lua-script properly
| + "if t ~= 0 then " | ||
| + "local expireIdle = redis.call('zscore', KEYS[3], ARGV[2]); " | ||
| + "if expireIdle ~= false then " | ||
| "local v = redis.call('hget', KEYS[1], ARGV[2]); " |
There was a problem hiding this comment.
@johnou please format this lua-script properly
|
|
||
| + "return val; ", | ||
| Arrays.<Object>asList(getName(key), getTimeoutSetNameByKey(key), getIdleSetNameByKey(key), getUpdatedChannelNameByKey(key)), | ||
| "local value = redis.call('hget', KEYS[1], ARGV[2]); " |
There was a problem hiding this comment.
@johnou please format this lua-script properly
zuanoc
force-pushed
the
feature/map_cache_max_size
branch
2 times, most recently
from
edb4e9b
to
8e906ba
Compare
|
@mrniko PTAL |
mrniko
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently RedissonMapCache creates an unbounded set in Redis which may cause problems in certain cache implementations.
Thanks for the heavy lifting @zuanoc !