Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with Travis CI #99

Merged
merged 2 commits into from
Mar 10, 2015
Merged

Run tests with Travis CI #99

merged 2 commits into from
Mar 10, 2015

Conversation

rouge8
Copy link
Contributor

@rouge8 rouge8 commented Mar 5, 2015

Use Travis CI to build pull requests and branches.

@rouge8
Copy link
Contributor Author

rouge8 commented Mar 5, 2015

@dcreager if this passes, should it go into the C-template for all our public C libraries?

@rouge8 rouge8 force-pushed the feature/travis-ci branch 2 times, most recently from db6fb5d to efb050d Compare March 5, 2015 20:02
@johnzachary
Copy link
Collaborator

I am not in favor of putting this in c-template.

@dcreager
Copy link
Owner

dcreager commented Mar 5, 2015

It would make it easier to include this with all of our libraries, though our internal projects would immediately remove these edits since Travis wouldn't be able to see our private repos. (Yes there's a way to make it but I'm not ready to open that can of worms yet.)

@rouge8
Copy link
Contributor Author

rouge8 commented Mar 5, 2015

Travis wouldn't be able to see our private repos

Travis is also not free for private repos. For private repos, we can use Jenkins + Docker images like our other projects. I still prefer Travis for public repos because it makes it easier for any potential contributors.

@dcreager dcreager force-pushed the feature/travis-ci branch 2 times, most recently from 1e47b62 to f2b28fd Compare March 10, 2015 17:42
Use [Travis CI](https://travis-ci.org) to build pull requests and
branches.  Travis only provides 64-bit build VMs, so we use some
multilib magic to test both 32- and 64-bit builds.
@dcreager
Copy link
Owner

I've pushed up a new patch that tests both 32-bit and 64-bit builds, using both clang and gcc. It'd be nice to also be able to automatically test on OS X, but Travis is currently at capacity with their OS X infrastructure.

@@ -1,5 +1,7 @@
# libcork

[![Build Status](https://img.shields.io/travis/redjack/libcork/develop.svg)](https://travis-ci.org/redjack/libcork)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge this to master, we should update the build status link.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@rouge8
Copy link
Contributor Author

rouge8 commented Mar 10, 2015

👍

Travis also [supports](http://docs.travis-ci.com/user/multi-os/)
building on OS X.
@dcreager
Copy link
Owner

Ah well, it was worth a shot. The latest patch updates the travis scripts to work on OS X (tested on my MBP), but Travis isn't showing the OS X builds in the matrix. If at any point we can convince Travis to turn on OS X builds for libcork, then our build scripts will be ready for it.

dcreager pushed a commit that referenced this pull request Mar 10, 2015
@dcreager dcreager merged commit 1af730f into develop Mar 10, 2015
@dcreager dcreager deleted the feature/travis-ci branch March 10, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants